-
Notifications
You must be signed in to change notification settings - Fork 875
[EuiToolTip] Refactor to a functional component, memoize style and improve tests #9570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
7204c9d
7e4fec1
45cc756
451f7a5
221f34e
fcc3c7e
d7c08d6
722bc07
b806650
d226eb5
a38e23d
402d1a1
88161ad
a89ee57
d9cec6d
cede9a3
03ca9cd
8a2d8e1
c508ee3
d827e24
eeac8f7
bb46282
38163a8
5ba550b
53bbe85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| */ | ||
|
|
||
| export type { ToolTipPositions } from './tool_tip_popover'; | ||
| export type { EuiToolTipProps } from './tool_tip'; | ||
| export type { EuiToolTipProps, EuiToolTipRef } from './tool_tip'; | ||
| export { EuiToolTip } from './tool_tip'; | ||
|
Comment on lines
9
to
11
|
||
|
|
||
| export type { EuiIconTipProps } from './icon_tip'; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an expected change. Previously,
positionleaked to the DOM element but it's not a valid HTML attribute. Same asoffset.