-
Notifications
You must be signed in to change notification settings - Fork 873
[EuiToolTip] Refactor to a functional component, memoize style and improve tests #9570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weronikaolejniczak
merged 25 commits into
elastic:main
from
weronikaolejniczak:chore/refactor-tooltip
Apr 28, 2026
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7204c9d
refactor(eui): migrate EuiToolTip to functional component
weronikaolejniczak 7e4fec1
refactor(eui): memoize EuiToolTip styles
weronikaolejniczak 45cc756
refactor(eui): update EuiToolTip usages
weronikaolejniczak 451f7a5
chore(eui): update VRT reference images
weronikaolejniczak 221f34e
chore(eui): update EuiToolTip test suite
weronikaolejniczak fcc3c7e
chore(eui): update EuiIconTip test suite
weronikaolejniczak d7c08d6
chore(eui): add filter select item tooltip test
weronikaolejniczak 722bc07
REMOVE BEFORE MERGE - temp stories
weronikaolejniczak b806650
refactor(eui): update nits after review
weronikaolejniczak d226eb5
fix(eui): fix tooltip reposition on resize window
weronikaolejniczak a38e23d
fix(eui): position tooltip on mount fixing StrictMode
weronikaolejniczak 402d1a1
chore(eui): just some formatting weirdness
weronikaolejniczak 88161ad
refactor(eui): narrow types in EuiToolTip
weronikaolejniczak a89ee57
chore(eui): change test to it in filter select item test
weronikaolejniczak d9cec6d
fix(eui): use ref on htmlIdGenerator return value
weronikaolejniczak cede9a3
chore(eui): update assertions in EuiIconTip tests
weronikaolejniczak 03ca9cd
chore(eui): rephrase stale comment
weronikaolejniczak 8a2d8e1
chore(eui): update comment
weronikaolejniczak c508ee3
Merge remote-tracking branch 'upstream/main' into chore/refactor-tooltip
tkajtoch d827e24
chore(eui): fix the typo in comment
weronikaolejniczak eeac8f7
chore(eui): add a test for StrictMode autoFocus
weronikaolejniczak bb46282
fix(eui): fix tooltip not showing on autoFocus in StrictMode
weronikaolejniczak 38163a8
fix(eui): wrap hideToolTip with isMounted condition
weronikaolejniczak 5ba550b
chore: revert temp stories
weronikaolejniczak 53bbe85
Merge branch 'main' into chore/refactor-tooltip
weronikaolejniczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-12 Bytes
(100%)
packages/eui/.loki/reference/chrome_desktop_Display_EuiImage_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.2 KB
...ui/.loki/reference/chrome_desktop_Forms_EuiFilePicker_Controlled_With_Files.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-24.8 KB
(63%)
...e/chrome_desktop_Forms_EuiForm_EuiFormControlButton_High_Contrast_Dark_Mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-24.9 KB
(63%)
...oki/reference/chrome_desktop_Forms_EuiForm_EuiFormControlButton_Kitchensink.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...ce/chrome_desktop_Forms_EuiForm_EuiFormControlLayoutDelimited_High_Contrast.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...nce/chrome_desktop_Forms_EuiForm_EuiFormControlLayoutDelimited_Kitchen_Sink.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4 Bytes
(100%)
...e/chrome_desktop_Forms_EuiForm_EuiFormControlLayout_High_Contrast_Dark_Mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
packages/eui/.loki/reference/chrome_mobile_Display_EuiImage_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.6 KB
...eui/.loki/reference/chrome_mobile_Forms_EuiFilePicker_Controlled_With_Files.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an expected change. Previously,
positionleaked to the DOM element but it's not a valid HTML attribute. Same asoffset.