Skip to content

[BREAKING] Fix TrustedOrigins default issue #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saoirse-a wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BREAKING] Fix TrustedOrigins default issue #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83add80
[BREAKING] Fix TrustedOrigins default issue
saoirse-a Apr 16, 2026
334dc55
Add changelog
saoirse-a Apr 17, 2026
b9a648c
remove the inherent default method from TrustedOrigins
saoirse-a Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions biscuit-auth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
for custom types should implement `From<MyType> for Term` instead.
- The `set_macro_param` and `set_macro_scope_param` methods are removed; macros now call
`set_lenient` and `set_scope_lenient`.
- `TrustedOrigin`'s `Default` implementation changed to match its previous inherent `default`
function (#327)

# `6.0.0`

Expand Down
9 changes: 5 additions & 4 deletions biscuit-auth/src/datalog/origin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,19 @@ impl Display for Origin {
}

/// This represents the sets of origins trusted by a rule
#[derive(Clone, Debug, Default, Hash, PartialEq, Eq, PartialOrd, Ord)]
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
pub struct TrustedOrigins(Origin);

#[allow(clippy::should_implement_trait)]
impl TrustedOrigins {
pub fn default() -> TrustedOrigins {
impl Default for TrustedOrigins {
fn default() -> TrustedOrigins {
let mut origins = Origin::default();
origins.insert(usize::MAX);
origins.insert(0);
TrustedOrigins(origins)
}
}

impl TrustedOrigins {
pub fn from_scopes(
rule_scopes: &[Scope],
default_origins: &TrustedOrigins,
Expand Down