[BREAKING] Fix TrustedOrigins default issue - #327
Open
saoirse-a wants to merge 3 commits into
Open
Conversation
Contributor
|
Could you add an entry in the changelog as well? |
Contributor
Author
|
Added to the changelog under 7.0.0 |
Geal
approved these changes
Jul 24, 2026
Contributor
|
Since #334 is moving on, I guess we have a strong case for a major release |
Contributor
|
@saoirse-a I’ll merge #334 first, can you rebase this one on top of main afterwards? I’ll merge it then |
TrustedOrigins implements an inherent constructor called default and also has a derived implementation of Default. **These two constructors have different behavior.** This means that `TrustedOrigins::default()` and `<TrustedOrigins as Default>::default()` construct different `TrustedOrigins` types. This is surprising. This PR changes the behavior of the Default trait constructor to match the behavior of the inherent constructor.
saoirse-a
force-pushed
the
trusted-origin-default
branch
from
August 11, 2026 12:38
e101081 to
334dc55
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
Actually I also updated it to delete the inherent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrustedOrigins implements an inherent constructor called default and also has a derived implementation of Default. These two constructors have different behavior.
This means that
TrustedOrigins::default()and<TrustedOrigins as Default>::default()construct differentTrustedOriginstypes. This is surprising.This PR changes the behavior of the Default trait constructor to match the behavior of the inherent constructor.