Skip to content

JIT: Move invariant nodes and LCL_VARs in LiftLIREdges #128250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jakobbotsch wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −14
Draft

JIT: Move invariant nodes and LCL_VARs in LiftLIREdges #128250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b336867
JIT: Move invariant nodes and LCL_VARs in LiftLIREdges
jakobbotsch May 15, 2026
585eab1
Fix
jakobbotsch May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions src/coreclr/jit/async.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,24 +1071,29 @@ void AsyncTransformation::LiftLIREdges(BasicBlock* block,

for (GenTree* tree : defs)
{
// TODO-CQ: Enable this. It currently breaks our recognition of how the
// call is stored.
// if (tree->OperIs(GT_LCL_VAR))
//{
// LclVarDsc* dsc = m_compiler->lvaGetDesc(tree->AsLclVarCommon());
// if (!dsc->IsAddressExposed())
// {
// // No interference by IR invariants.
// LIR::AsRange(block).Remove(tree);
// LIR::AsRange(block).InsertAfter(beyond, tree);
// continue;
// }
//}

LIR::Use use;
bool gotUse = LIR::AsRange(block).TryGetUse(tree, &use);
assert(gotUse); // Defs list should not contain unused values.

if (tree->IsInvariant())
{
LIR::AsRange(block).Remove(tree);
LIR::AsRange(block).InsertBefore(use.User(), tree);
continue;
}

if (tree->OperIs(GT_LCL_VAR))
{
LclVarDsc* dsc = m_compiler->lvaGetDesc(tree->AsLclVarCommon());
if (!dsc->IsAddressExposed())
{
// No interference by IR invariants
LIR::AsRange(block).Remove(tree);
LIR::AsRange(block).InsertBefore(use.User(), tree);
continue;
}
}

unsigned newLclNum = use.ReplaceWithLclVar(m_compiler);
layoutBuilder->AddLocal(newLclNum);
GenTree* newUse = use.Def();
Expand Down
Loading