JIT: Move invariant nodes and LCL_VARs in LiftLIREdges#128250
Draft
jakobbotsch wants to merge 2 commits into
Draft
JIT: Move invariant nodes and LCL_VARs in LiftLIREdges#128250jakobbotsch wants to merge 2 commits into
jakobbotsch wants to merge 2 commits into
Conversation
Invariant nodes and LCL_VARs do not need to be lifted across async calls.
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR JIT async state machine lowering (AsyncTransformation::LiftLIREdges) to avoid lifting certain “live LIR edge” values across async suspension points by moving them closer to their use instead of materializing spill locals.
Changes:
- Move invariant nodes (
GenTree::IsInvariant) to just before their use so they are no longer live across the async call. - Attempt to treat some
GT_LCL_VARnodes similarly (skip lift if the local isn’t address-exposed) by relocating the node instead of spilling to a new temp local.
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invariant nodes and LCL_VARs do not need to be lifted across async calls.
Prerequisite for #128152 since it ensures we do not lift
LCL_ADDRdefs.