-
Notifications
You must be signed in to change notification settings - Fork 801
native modules: build rust workspace crates through the repo flake #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
5241122
112c9d5
0d216be
4cd942a
6ab3467
7a4f671
e4eb3f8
12c5ae2
ac844e9
6d274a2
8a9dc1a
d08156f
d06824e
7d19b37
5def8fd
7ea8f45
701453c
8b4e3fa
c70d595
3f6653f
776cb45
0e1d204
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -35,7 +35,11 @@ class RayTracingVoxelMapConfig(NativeModuleConfig): | |||||
| cwd: str | None = "rust" | ||||||
| # The crate is a workspace member, so cargo builds into the repo-root target dir. | ||||||
| executable: str = str(DIMOS_PROJECT_ROOT / "target" / "release" / "voxel_ray_tracing") | ||||||
| build_command: str | None = "cargo build --release" | ||||||
| # The repo flake supplies cargo: rustup's PATH entry is absent in non-interactive | ||||||
| # shells (ssh commands, systemd units). Relative to cwd rather than | ||||||
| # DIMOS_PROJECT_ROOT so it stays a literal the CI inputs hash can read, and because | ||||||
| # nix resolves it against the real cwd, sidestepping symlinked components (macOS /tmp). | ||||||
| build_command: str | None = "nix develop path:../../../.. -c cargo build --release" | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
So if we use path that will cause the entire workspace to get snapshotted on every build, can you double check this isn't going to spam the nix store?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah... I'm afraid this is looking like a "pick your poison" kinda decision. I've got a couple ideas but I'm gonna have to do testing. |
||||||
| stdin_config: bool = True | ||||||
|
|
||||||
| voxel_size: float = 0.1 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,7 +31,11 @@ class MLSPlannerNativeConfig(NativeModuleConfig): | |||||
| cwd: str | None = "rust" | ||||||
| # The crate is a workspace member, so cargo builds into the repo-root target dir. | ||||||
| executable: str = str(DIMOS_PROJECT_ROOT / "target" / "release" / "mls_planner") | ||||||
| build_command: str | None = "cargo build --release" | ||||||
| # The repo flake supplies cargo: rustup's PATH entry is absent in non-interactive | ||||||
|
jeff-hykin marked this conversation as resolved.
Outdated
|
||||||
| # shells (ssh commands, systemd units). Relative to cwd rather than | ||||||
| # DIMOS_PROJECT_ROOT so it stays a literal the CI inputs hash can read, and because | ||||||
| # nix resolves it against the real cwd, sidestepping symlinked components (macOS /tmp). | ||||||
| build_command: str | None = "nix develop path:../../../../.. -c cargo build --release" | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| stdin_config: bool = True | ||||||
|
|
||||||
| world_frame: str = "odom" | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.