Skip to content

[DGS-4423] Add per-document timestamp settings - #417

Merged
PavelVais merged 5 commits into
2.xfrom
dgs-4423-per-document-timestamps
Aug 13, 2026
Merged

[DGS-4423] Add per-document timestamp settings#417
PavelVais merged 5 commits into
2.xfrom
dgs-4423-per-document-timestamps

Conversation

@PavelVais

@PavelVais PavelVais commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Mirrors API changes — per-document timestamp settings on envelopes and templates.

Added

  • EnvelopeDocument.timestampEnabled (bool) and EnvelopeDocument.timestampsRenewalPeriod (?int, years, -1 = unlimited, null = disabled)
  • EnvelopeTemplateDocument.timestampEnabled and EnvelopeTemplateDocument.timestampsRenewalPeriod
  • EnvelopeProperties.defaultTimestampDocuments — default seed for per-document timestampEnabled
  • EnvelopeProperties.timestampAuditLogRenewalPeriod — audit log renewal period

Changed

  • EnvelopeProperties.timestampsRenewalPeriod renamed to defaultTimestampsRenewalPeriodbreaking, approved: field is new from DGS-4362 and the renewal engine does not exist yet, no real consumers
  • EnvelopeProperties.timestampDocuments and EnvelopeTemplate.timestampDocuments deprecated in favor of defaultTimestampDocuments (API keeps both keys in output for now; old keys will be dropped in a follow-up ticket)

Checks

  • PHPUnit: 361 tests OK
  • PHPStan: OK (--memory-limit=2G)

🤖 Generated with Claude Code

pavelvais and others added 3 commits August 13, 2026 12:53
- Add `EnvelopeDocument.timestampEnabled` and `EnvelopeDocument.timestampsRenewalPeriod`
- Add `EnvelopeTemplateDocument.timestampEnabled` and `EnvelopeTemplateDocument.timestampsRenewalPeriod`
- Add `EnvelopeProperties.defaultTimestampDocuments` and `EnvelopeProperties.timestampAuditLogRenewalPeriod`
- Rename `EnvelopeProperties.timestampsRenewalPeriod` to `defaultTimestampsRenewalPeriod`
- Deprecate `timestampDocuments` on `EnvelopeProperties` and `EnvelopeTemplate` in favor of `defaultTimestampDocuments`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Composer 2.9 blocks installation of squizlabs/php_codesniffer 3.8/3.9
due to security advisory PKSA-rdkp-vv9z-mjkg; coding-standard ^0.3.0
allows php_codesniffer 3.13.* where the advisory is fixed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
slevomat/coding-standard 8.19.0 combined with php_codesniffer 3.13
reports a false positive (MultipleSpacesBetweenTypeHintAndProperty)
on the untyped FileStream::$handle property; 8.19.1 fixes property
detection. digitalcz/coding-standard only constrains it to 8.19.*,
so prefer-lowest picked the broken 8.19.0.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (86ee8c5) to head (5147212).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #417   +/-   ##
=========================================
  Coverage     97.83%   97.83%           
  Complexity      533      533           
=========================================
  Files            87       87           
  Lines          1246     1246           
=========================================
  Hits           1219     1219           
  Misses           27       27           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pavelvais and others added 2 commits August 13, 2026 14:23
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@PavelVais
PavelVais merged commit 12a0f09 into 2.x Aug 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants