Remove EnvelopeTemplate.defaultTimestampDocuments in favor of properties - #419
Merged
Conversation
The API keeps the default timestamp setting only on EnvelopeProperties; the top-level EnvelopeTemplate field stays as the deprecated timestampDocuments alias. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #419 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 533 533
=========================================
Files 87 87
Lines 1246 1246
=========================================
Hits 1219 1219
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tomasDostalDS
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #417 — review on the API MR concluded the default timestamp setting must live only on
EnvelopeProperties, not as a new top-level field. The API keeps the deprecated top-leveltimestampDocumentsalias until a follow-up ticket removes it.EnvelopeTemplate.defaultTimestampDocuments(unreleased, added in [DGS-4423] Add per-document timestamp settings #417)EnvelopeTemplate.timestampDocumentsdeprecation toEnvelopeProperties.defaultTimestampDocuments🤖 Generated with Claude Code