Skip to content

fix: Ensure we reset state when changing sources in MultiCOGLayer #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 1 commit into from
Apr 10, 2026
Merged

fix: Ensure we reset state when changing sources in MultiCOGLayer #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/deck.gl-geotiff/src/multi-cog-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,19 @@ export class MultiCOGLayer extends CompositeLayer<MultiCOGLayerProps> {
});
}

override updateState({ changeFlags }: UpdateParameters<this>): void {
if (changeFlags.dataChanged || changeFlags.propsChanged) {
override updateState({
changeFlags,
props,
oldProps,
}: UpdateParameters<this>): void {
if (changeFlags.dataChanged || props.sources !== oldProps.sources) {
// Reset state so renderLayers() returns null while we re-open COGs.
// Without this, the TileLayer renders with new props but stale state,
// caching tiles with the wrong bands.
this.setState({
sources: null,
multiDescriptor: null,
});
this._parseAllSources();
}
}
Expand Down Expand Up @@ -494,6 +505,10 @@ export class MultiCOGLayer extends CompositeLayer<MultiCOGLayerProps> {
0,
);

console.log(
`Tile (${x}, ${y}, ${z}): fetched bands [${[...bands.keys()].join(", ")}], total byte length: ${byteLength}`,
);

return {
bands,
forwardTransform,
Expand Down