fix: Ensure we reset state when changing sources in MultiCOGLayer#414
Merged
kylebarron merged 1 commit intomainfrom Apr 10, 2026
Merged
fix: Ensure we reset state when changing sources in MultiCOGLayer#414kylebarron merged 1 commit intomainfrom
kylebarron merged 1 commit intomainfrom
Conversation
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #142, related to #147
Previously, switching sources rendered old data. Now, we correctly render the latest data whenever we switch sources.
Screen.Recording.2026-04-10.at.3.25.28.PM.mov
Root cause:
_parseAllSources()is async, butrenderLayers()runs synchronously afterupdateState. The newTileLayerwas created with new props-derivedsourceUrlsin its id/updateTriggers, causing tile re-fetches. But_getTileDataread band data fromthis.state.sourceswhich still held the old source map. Tiles were cached under the newTileLayerwith wrong band names, and when_parseAllSourcesfinally completed, the cached tiles persisted — causing_renderSubLayersto returnnull(required bands missing).