Skip to content

Paginate descendent places #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nick-nlb merged 3 commits into from
Jul 10, 2026
Merged

Paginate descendent places #6443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fde68de
Set default max_pages to None in descendent_places to allow fetching …
nick-nlb Jul 10, 2026
5e0af4c
Add corresponding pagination directive (and default pagination value)…
nick-nlb Jul 10, 2026
d41f862
Merge branch 'master' into paginate-descendent-places
nick-nlb Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions server/lib/fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ def triples(nodes, out=True, max_pages=1):
return result


def descendent_places(nodes, descendent_type, max_pages=1):
def descendent_places(nodes, descendent_type, max_pages=None):
Comment thread
nick-nlb marked this conversation as resolved.
# When the only node being requested is also the descendent_type, fetch all nodes of that type.
if nodes and len(nodes) == 1 and nodes[0] == descendent_type:
return property_values(nodes, "typeOf", out=False, max_pages=max_pages)
Expand All @@ -523,12 +523,13 @@ def descendent_places(nodes, descendent_type, max_pages=1):
max_pages=max_pages)


def raw_descendent_places(nodes, descendent_type):
def raw_descendent_places(nodes, descendent_type, max_pages=None):
return raw_property_values(
nodes,
'containedInPlace+',
out=False,
constraints='{{typeOf:{}}}'.format(descendent_type))
constraints='{{typeOf:{}}}'.format(descendent_type),
max_pages=max_pages)


def resolve_id(nodes, in_prop, out_prop):
Expand Down
Loading