Paginate descendent places

[nick-nlb]

Description

With Spanner [correctly] paginating the results of v2 node, the descendent_places call in Flask was only delivering partial results (the first page) for larger collections of descendents.

This PR sets default max_pages to None in descendent_places to allow fetching all pages (triggering a fetch of all places).

Screenshots

The following screenshots are taken using Spanner as a backend:

Before

After

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the descendent_places function was only returning the first page of results, causing incomplete data retrieval for larger collections when using the Spanner backend. By defaulting max_pages to None, the function now correctly fetches all available pages.

Highlights

• Pagination Update: Updated the default value of the max_pages parameter in the descendent_places function from 1 to None to ensure all pages are fetched.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the descendent_places function in server/lib/fetch.py to default max_pages to None instead of 1, preventing arbitrary pagination limits. The reviewer suggests applying a similar change to raw_descendent_places to avoid partial results.

[n-h-diaz]

Thanks!