Port entities sample to DCP#150
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new dataset for Alaska hospital unplanned visits, including entity and observation CSV files, an import configuration JSON, and an MCF schema. The review feedback suggests improving naming consistency by changing the capitalized 'City' column header in the entities CSV to lowercase 'city', and updating the corresponding reference in the configuration file.
| @@ -0,0 +1,22 @@ | |||
| facility_id,name,address,City,zip | |||
There was a problem hiding this comment.
The column header 'City' is capitalized, while all other headers ('facility_id', 'name', 'address', 'zip') are lowercase. Using lowercase 'city' ensures consistent naming conventions across all column headers.
facility_id,name,address,city,zip
There was a problem hiding this comment.
This is intended to indicate that this is an existing DCID. Not sure if the "dcid:" prefix should be specified as well.
| "rowEntityType": "Hospital", | ||
| "idColumn": "facility_id", | ||
| "entityColumns": [ | ||
| "City", |
There was a problem hiding this comment.
Update the entity column reference to 'city' to match the lowercase column header in 'alaska_hospital_entities.csv'.
| "City", | |
| "city", |
|
This might need to only be submitted after we cut a new version i think? Otherwise if someone copies this sample but tries to run the v1.0.0 it wouldnt work |
|
SG. I'll wait to merge it. Thanks, Gabe.
…On Tue, Jun 30, 2026 at 10:25 AM Gabriel Mechali ***@***.***> wrote:
*gmechali* left a comment (datacommonsorg/datacommons#150)
<#150 (comment)>
This might need to only be submitted after we cut a new version i think?
Otherwise if someone copies this sample but tries to run the v1.0.0 it
wouldnt work
—
Reply to this email directly, view it on GitHub
<#150?email_source=notifications&email_token=BHMM7UCKHXTHHWMPHL4AR2L5CPZY5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBUGYYTQNZYGQZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4846187842>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHMM7UCIQWBLHGM2GT6IH3L5CPZY5AVCNFSNUABFKJSXA33TNF2G64TZHM4TQMBSGYYTGMZWHNEXG43VMU5TINZXGIYTINJWGEYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BHMM7UANDXZ44SSX3ZGQPX35CPZY5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBUGYYTQNZYGQZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BHMM7UFCZSDPKA33YY4R3PD5CPZY5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBUGYYTQNZYGQZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2 participants
This PR updates the CDC non-place entities sample for DCP. Currently it uses single entity (hospital). Once multi-entity is fully supported, it will be a nice example to use statvar 2 entities: hospital and illness (type).