Update OECD samples to split out MCF#151
Merged
Merged
Conversation
This reverts commit 07fc3f1.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the OECD wage data samples by moving the definitions for OECDWages and average_annual_wage from gender_wage_gap.mcf into a new dedicated file average_annual_wage.mcf. It also updates the file patterns in config.json to use wildcards. The reviewer pointed out that using wildcard patterns like .* matches both CSV and MCF files, which can cause the importer to incorrectly attempt to parse MCF files as CSVs. It is recommended to restrict these patterns to target only the .csv files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Gabe's recommendation on PR #146, this splits out the MCF so that the statvar definitions are paired with the CSVs and there should be no duplicate edges.