Skip to content

fix(lakebase): follow next_page_token when listing Postgres projects #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karen-amaya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(lakebase): follow next_page_token when listing Postgres projects #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 34 additions & 27 deletions src/back/core/databricks/lakebase/LakebaseAuth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,34 +335,41 @@ def _lookup_via_postgres_api(self, host: str) -> Optional[str]:
api = getattr(self._w, "api_client", None)
if api is None or not hasattr(api, "do"):
return None
projects = (api.do("GET", "/api/2.0/postgres/projects") or {}).get(
"projects"
) or []
for project in projects:
project_path = project.get("name") or ""
if not project_path:
continue
branches = (
api.do("GET", f"/api/2.0/postgres/{project_path}/branches") or {}
).get("branches") or []
for branch in branches:
branch_path = branch.get("name") or ""
if not branch_path:
# /api/2.0/postgres/projects is paginated - a workspace with more
# projects than fit on one page silently hides later ones from a
# single unpaginated call, so we must follow next_page_token.
page_token: Optional[str] = None
while True:
query = {"page_token": page_token} if page_token else None
resp = api.do("GET", "/api/2.0/postgres/projects", query=query) or {}
projects = resp.get("projects") or []
for project in projects:
project_path = project.get("name") or ""
if not project_path:
continue
endpoints = (
api.do("GET", f"/api/2.0/postgres/{branch_path}/endpoints")
or {}
).get("endpoints") or []
for endpoint in endpoints:
hosts = (endpoint.get("status") or {}).get("hosts") or {}
h = (hosts.get("host") or "").strip().lower()
ro = (hosts.get("read_only_host") or "").strip().lower()
if host in (h, ro):
endpoint_path = endpoint.get("name") or ""
if endpoint_path:
self._endpoint_resource = endpoint_path
return project_path.rsplit("/", 1)[-1]
return None
branches = (
api.do("GET", f"/api/2.0/postgres/{project_path}/branches") or {}
).get("branches") or []
for branch in branches:
branch_path = branch.get("name") or ""
if not branch_path:
continue
endpoints = (
api.do("GET", f"/api/2.0/postgres/{branch_path}/endpoints")
or {}
).get("endpoints") or []
for endpoint in endpoints:
hosts = (endpoint.get("status") or {}).get("hosts") or {}
h = (hosts.get("host") or "").strip().lower()
ro = (hosts.get("read_only_host") or "").strip().lower()
if host in (h, ro):
endpoint_path = endpoint.get("name") or ""
if endpoint_path:
self._endpoint_resource = endpoint_path
return project_path.rsplit("/", 1)[-1]
page_token = resp.get("next_page_token")
if not page_token:
return None

def _ensure_workspace(self) -> None:
"""Lazily build the workspace client."""
Expand Down