fix(lakebase): follow next_page_token when listing Postgres projects - #161
Open
karen-amaya wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_lookup_via_postgres_apicallsGET /api/2.0/postgres/projectsonce without followingnext_page_token. That endpoint paginates at 10 projects/page, so in workspaces with more than 10 Postgres projects, an project past page 1 is invisible to this lookup — causing the misleading error "No Lakebase Autoscaling endpoint matched... legacy Provisioned instances are not supported", even with a valid, correctly-permissioned project.Confirmed in production (2026-09-04): the project was on page 2 of 19. Fix: loop over
next_page_tokenuntil exhausted.Linked Issue / milestone
Closes #160
Plan
N/A — single-file fix, no formal plan doc for this one.
Type of change
Author checklist
<type>(<scope>): <subject>).changelogs/<today>.logupdated with title + context + numbered changes + files + test result.uv run pytest tests/<scope>/green locally.pre-commit run --all-filesclean (or skipped hooks documented).src/agents/**or any MLflow-traced LLM path changed:SPEC.mdpresent in.planning/<slug>/.tests/eval/datasets/<agent>/dataset.jsonlhas ≥20 examples (new) or ≥10 (change).src/mcp-server/**changed:uv run pytest tests/mcp/ -m mcpgreen.gsd-*references re-introduced.MLflow eval run
Test plan
uv run pytest tests/ -m "not e2e and not property and not eval" --cov-fail-under=90scripts/check_coverage.py) green for touched packages.uv run pytest tests/mcp/integration/test_tool_schemas.pyincludes it.Reviewer hint
See
docs/PR_REVIEW_CHECKLIST.md. Numbered items map 1:1 to comments —#3: missing OntoBricksError subclass for new conditionis more useful than "fix error handling".