Add 8.9 removal notice to deprecation warnings by MetRonnie · Pull Request #7509 · cylc/cylc-flow

MetRonnie · 2026-10-05T17:54:42Z

Partially addresses #7278

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
No dependency changes
Tests are included (or explain why tests are not needed).
Changelog entry not needed
Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

MetRonnie · 2026-10-06T12:33:53Z

-    # BACK COMPAT: post_load_db_coerce
-    # The DB at 8.0.x stores Interval values as neither ISO8601 duration
-    # string or DurationFloat. This has been fixed at 8.1.0.
-    # url:
-    #     https://github.com/cylc/cylc-flow/pull/5138
-    # from:
-    #    8.0.x
-    # to:
-    #    8.1.x
-    # remove at:
-    #    8.7


This comment now only applies to a specific method of the BroadcastConfigValidator - there is already a comment over there:

cylc-flow/cylc/flow/parsec/validate.py

Lines 1313 to 1322 in f778c0f

# BACK COMPAT: BroadcastConfigValidator.coerce_interval

# The DB at 8.0.x stores Interval values as neither ISO8601 duration

# string or DurationFloat. This has been fixed at 8.1.0, and

# the following method acts as a bridge between fixed and broken.

# url: https://github.com/cylc/cylc-flow/pull/5138

# from: 8.0

# to: 8.1

# remove after: https://github.com/cylc/cylc-flow/issues/7339

@classmethod

def coerce_interval(cls, value, keys):

MetRonnie · 2026-10-06T14:16:34Z

-        # BACK COMPAT: contact pre "suite" to "workflow" conversion.
-        # from:
-        #     Cylc 8
-        # remove at:
-        #     Cylc 8.x
-        data[key.replace('SUITE', 'WORKFLOW')] = value


Removed support for Cylc 7 contact files - I think at 8.7 we have agreed there should not be support for interacting with running Cylc 7 workflows.

(I checked this function is not used in cylc-uiserver)

jfrost-mo

Looks like a sensible set of additional deprecation warnings/markers. The first comment in cylc/flow/scheduler.py is the only one I feel strongly about, otherwise just minor queries.

jfrost-mo · 2026-10-06T15:27:39Z

+    # remove at: 8.x (pending a deprecation warning mentioning the removal
+    # version at least 2 minor versions before)


Should we define this warning?

Will do later when we get round to it, don't want to delay this PR

jfrost-mo · 2026-10-06T15:28:00Z

+    # remove at: 8.x (pending a deprecation warning mentioning the removal
+    # version at least 2 minor versions before)


Should we define this warning?

jfrost-mo

Looking sensible; cylc 7 really permeates this codebase.

Only comment is about another bit of code the could be removed, but that really wants to happen in a separate PR. Therefore happy to approve this one.

jfrost-mo · 2026-10-07T08:09:27Z

Also looks like some functional test KGOs need updating.

MetRonnie · 2026-10-07T11:20:45Z

Rebased onto master to bring in the changes from #7489

MetRonnie · 2026-10-07T11:30:42Z

+    # BACK COMPAT: suite.rc logic
+    # FROM: 8.0
+    # TO: 8.7
+    # REMOVE AT: 8.11


8.11 timescale was set in https://github.com/cylc/cylc-flow/pull/7325/changes#diff-bbe6f7254b92c1923735b6736de6e6699e23bcfec35c7915234358a0440a019d

Opened an issue for the eventual removal: #7511

jfrost-mo

Reviewed the diff and it looks good.

oliver-sanders · 2026-10-07T15:40:21Z

+                    return False
                else:
-                    # ... can be run by Cylc 8


Discussed in person, I will remove the functional change to scan as we still want to display suite.rc workflows in the GUI so users can start them with an earlier version of Cylc 8 using the play form, for example

oliver-sanders · 2026-10-07T15:44:53Z

-    # TO: 8.6.*
-    # REMOVE: 8.8
+    # TO: 8.7
+    # REMOVE AT: 8.10


Shouldn't this be 8.11 (four minor version window?).

Depends how you count (inclusive of the to: version or not)?

I was basing it off

cylc-flow/cylc/flow/commands.py

Lines 118 to 122 in 5023ff9

# BACK COMPAT: handle --flow=all from earlier clients

# FROM: 8.0

# TO: 8.5.0

# REMOVE AT: 8.8

def back_compat_flow_all(flow: List[str]) -> List[str]:

cylc-flow/cylc/flow/commands.py

Lines 386 to 392 in 5023ff9

# BACK COMPAT: mode=None

# the mode can be `None` for commands issued from older Cylc

# versions

# From: 8.4

# To: 8.5

# Remove at: 8.8

mode = StopMode(mode.value) if mode else StopMode.REQUEST_CLEAN

…ronment templates`

MetRonnie added this to the 8.7.0 milestone Oct 5, 2026

MetRonnie self-assigned this Oct 5, 2026

oliver-sanders reviewed Oct 6, 2026

View reviewed changes

Comment thread cylc/flow/rundb.py Outdated

oliver-sanders reviewed Oct 6, 2026

View reviewed changes

Comment thread cylc/flow/task_events_mgr.py Outdated

MetRonnie force-pushed the delete-back-compat branch from dc02bf8 to c0a3b4d Compare October 6, 2026 12:14

MetRonnie marked this pull request as ready for review October 6, 2026 12:32

MetRonnie force-pushed the delete-back-compat branch from c0a3b4d to f778c0f Compare October 6, 2026 12:32

MetRonnie requested review from jfrost-mo and oliver-sanders October 6, 2026 12:32

MetRonnie commented Oct 6, 2026

View reviewed changes

jfrost-mo reviewed Oct 6, 2026

View reviewed changes

MetRonnie mentioned this pull request Oct 6, 2026

turn Cylc 7 deprecated syntax warnings into errors #7367

Open

MetRonnie requested a review from jfrost-mo October 6, 2026 16:33

jfrost-mo approved these changes Oct 7, 2026

View reviewed changes

Comment thread cylc/flow/network/scan.py

MetRonnie marked this pull request as draft October 7, 2026 09:01

MetRonnie added 3 commits October 7, 2026 11:08

Add 8.9 removal notices to deprecation warnings

0a57d7b

Add 8.9 removal notices to deprecated task/workflow event template vars

be2f6fa

Remove support for Cylc 7 contact files

10d809c

MetRonnie force-pushed the delete-back-compat branch from a507fae to e5a0b43 Compare October 7, 2026 11:19

MetRonnie requested a review from jfrost-mo October 7, 2026 11:20

MetRonnie marked this pull request as ready for review October 7, 2026 11:21

MetRonnie commented Oct 7, 2026

View reviewed changes

MetRonnie mentioned this pull request Oct 7, 2026

Remove suite.rc functionality #7511

Open

jfrost-mo approved these changes Oct 7, 2026

View reviewed changes

oliver-sanders reviewed Oct 7, 2026

View reviewed changes

Comment thread cylc/flow/scripts/lint.py Outdated

oliver-sanders reviewed Oct 7, 2026

View reviewed changes

Comment thread cylc/flow/scripts/lint.py Outdated

oliver-sanders reviewed Oct 7, 2026

View reviewed changes

Comment thread cylc/flow/scheduler.py

MetRonnie added 4 commits October 7, 2026 17:13

Fix back compat comments

e16284d

Add 8.9 removal notices to deprecated event names and `parameter envi…

2f80311

…ronment templates`

Mop up Cylc 7 back compat mode stuff

1ba141b

Wait until 8.10 to remove shim for --no-spawn option

6fd6f49

MetRonnie force-pushed the delete-back-compat branch from 4ef90ee to 6fd6f49 Compare October 7, 2026 16:13

oliver-sanders approved these changes Oct 8, 2026

View reviewed changes

oliver-sanders merged commit 4e6c2d0 into cylc:master Oct 8, 2026
28 checks passed

MetRonnie deleted the delete-back-compat branch October 8, 2026 10:45

	# BACK COMPAT: BroadcastConfigValidator.coerce_interval
	# The DB at 8.0.x stores Interval values as neither ISO8601 duration
	# string or DurationFloat. This has been fixed at 8.1.0, and
	# the following method acts as a bridge between fixed and broken.
	# url: https://github.com/cylc/cylc-flow/pull/5138
	# from: 8.0
	# to: 8.1
	# remove after: https://github.com/cylc/cylc-flow/issues/7339
	@classmethod
	def coerce_interval(cls, value, keys):

		# remove at: 8.x (pending a deprecation warning mentioning the removal
		# version at least 2 minor versions before)

	# BACK COMPAT: handle --flow=all from earlier clients
	# FROM: 8.0
	# TO: 8.5.0
	# REMOVE AT: 8.8
	def back_compat_flow_all(flow: List[str]) -> List[str]:

	# BACK COMPAT: mode=None
	# the mode can be `None` for commands issued from older Cylc
	# versions
	# From: 8.4
	# To: 8.5
	# Remove at: 8.8
	mode = StopMode(mode.value) if mode else StopMode.REQUEST_CLEAN

Conversation

MetRonnie commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MetRonnie Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MetRonnie Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

jfrost-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jfrost-mo Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

MetRonnie Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

jfrost-mo Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jfrost-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jfrost-mo commented Oct 7, 2026

Uh oh!

MetRonnie commented Oct 7, 2026

Uh oh!

MetRonnie Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jfrost-mo left a comment

Choose a reason for hiding this comment

Uh oh!

oliver-sanders Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

MetRonnie Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

oliver-sanders Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

MetRonnie Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MetRonnie commented Oct 5, 2026 •

edited

Loading

MetRonnie Oct 6, 2026 •

edited

Loading

MetRonnie Oct 7, 2026 •

edited

Loading

MetRonnie Oct 7, 2026 •

edited

Loading