Skip to content

Announce when deprecated config settings will be removed - #7489

Merged
oliver-sanders merged 17 commits into
cylc:masterfrom
Scott-Owen-James:7366
Oct 6, 2026
Merged

oliver-sanders merged 17 commits into
cylc:masterfrom
Scott-Owen-James:7366

Conversation

@Scott-Owen-James

@Scott-Owen-James Scott-Owen-James commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #7366

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • changes: document 7489 (announce deprecated config removal at 8.9) cylc-doc#975
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@Scott-Owen-James Scott-Owen-James changed the title Added functionality for announcing when a deprecated items is removed Added functionality for announcing when a deprecated item is removed Sep 30, 2026
Comment thread cylc/flow/parsec/upgrade.py
@oliver-sanders oliver-sanders added this to the 8.7.0 milestone Sep 30, 2026
Comment thread cylc/flow/parsec/upgrade.py Outdated
Scott-Owen-James and others added 2 commits October 1, 2026 09:42
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@Scott-Owen-James Scott-Owen-James self-assigned this Oct 1, 2026
Comment thread tests/functional/deprecations/01-cylc8-basic/validation.stderr Outdated
WARNING - * (8.0.0) [cylc][events]mail to -> [cylc][mail]to - value unchanged - will be removed at 8.9
WARNING - * (8.0.0) [cylc][events]mail from -> [cylc][mail]from - value unchanged - will be removed at 8.9
WARNING - * (8.0.0) [cylc][events]mail footer -> [cylc][mail]footer - value unchanged - will be removed at 8.9
WARNING - * (8.0.0) [runtime][foo, cat, dog][events]mail to -> [runtime][foo, cat, dog][mail]to - value unchanged

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these have version numbers?

Comment thread tests/functional/deprecations/01-cylc8-basic/validation.stderr Outdated
Comment thread tests/functional/deprecations/01-cylc8-basic/validation.stderr Outdated
Comment thread cylc/flow/parsec/upgrade.py Outdated
Comment thread tests/functional/deprecations/01-cylc8-basic/validation.stderr Outdated
Comment thread tests/functional/deprecations/01-cylc8-basic/validation.stderr Outdated
Comment thread cylc/flow/cfgspec/workflow.py Outdated
Scott-Owen-James and others added 5 commits October 2, 2026 11:33
@MetRonnie MetRonnie changed the title Added functionality for announcing when a deprecated item is removed Announce when deprecated config settings will be removed Oct 2, 2026

@MetRonnie MetRonnie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this but more of a follow-up to #7325

diff --git a/cylc/flow/cfgspec/workflow.py b/cylc/flow/cfgspec/workflow.py
index e7610d6b0..a4e0d5d5d 100644
--- a/cylc/flow/cfgspec/workflow.py
+++ b/cylc/flow/cfgspec/workflow.py
@@ -2109,5 +2108,0 @@ def upg(
-    NOTE: We are silencing deprecation (and only deprecation) warnings
-    when in Cylc 7 compat mode to help support Cylc 7/8 compatible workflows
-    (which would loose Cylc 7 compatibility if users were to follow the
-    warnings and upgrade the syntax).
-

Comment thread cylc/flow/parsec/upgrade.py

@hjoliver hjoliver left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from a quick review. Not merging as I'm not sure if all the detailed comments have been addressed yet.

@MetRonnie MetRonnie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliver-sanders oliver-sanders left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliver-sanders
oliver-sanders merged commit 5dde9c5 into cylc:master Oct 6, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

communicate retirement version for Cylc 7 config syntax

4 participants