feat(diagnostics): Add support for heap dump analysis#506
Draft
Josh-Matsuoka wants to merge 5 commits into
Draft
feat(diagnostics): Add support for heap dump analysis#506Josh-Matsuoka wants to merge 5 commits into
Josh-Matsuoka wants to merge 5 commits into
Conversation
|
This PR/issue depends on:
|
7 tasks
andrewazores
reviewed
Jun 3, 2026
| @POST | ||
| public String getHeapDumpReportFromPresigned(RoutingContext ctx, @BeanParam PresignedHeapDumpFormData form) | ||
| throws IOException, URISyntaxException { | ||
| // TODO queue these requests so we don't overload ourselves, in particular by reading |
Member
There was a problem hiding this comment.
The resource contention issues here are even more potentially egregious with heap dumps than for JFR analysis, so it's probably worth trying to solve this or at least mitigate the potential negative effects now.
https://quarkus.io/guides/smallrye-fault-tolerance
A Bulkhead might be a good starting point.
Author
There was a problem hiding this comment.
I've added a Bulkhead to the report methods for now, I'll have to do some more research into the smallrye fault tolerance system and look at what we've done with other cryostat endpoints to if we should add anything else.
andrewazores
reviewed
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: cryostatio/cryostat#1127
Depends on cryostatio/cryostat-core#666
Adds support for generating heap dump analysis reports from cryostat-reports. Follows a similar strategy to how recording reports are generated and emitted.
Opening as draft pending any changes needed for frontend.