feat(diagnostics): Add support for heap dump analysis#666
feat(diagnostics): Add support for heap dump analysis#666Josh-Matsuoka wants to merge 4 commits into
Conversation
To run smoketest: |
| "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD", | ||
| "NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD" | ||
| }) | ||
| public HeapDumpAnalysis(String heapDumpId, String jvmId, InputStream inputStream) { |
There was a problem hiding this comment.
Please refactor this so that all the work is not done directly in the constructor. Maybe make it Runnable and move the work off into that method, so that the constructor is only doing the basic necessities of validating the parameters and assigning fields etc.
There was a problem hiding this comment.
I suppose if the heapDumpId and jvmId are removed then the only remaining parameter is the inputStream - but it's probably best that this is not passed in as a constructor field and assigned and then only later actually used in the "run" method.
So perhaps the best thing to do here is actually refactor this constructor into something like a public static HeapDumpAnalysis analyze(InputStream inputStream) throws IOException.
|
Looks like JOverflow is now in jmc-core snapshots: openjdk/jmc#720 https://packages.adoptium.net/ui/repos/tree/General/jmc-libs-snapshots/org/openjdk/jmc/joverflow |
To run smoketest: |
To run smoketest: |
2 participants
Related to: cryostatio/cryostat#1127
Adds preliminary support for Heap Dump analysis.
Opening as draft pending any changes needed for the frontend.