Conversation
9c3ad20 to
d6fb79d
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the remaining
go.podman.io/image/v5usage in the registry stack withgithub.com/regclient/regclient.The registry client is now implemented on top of
regclientfor manifest lookup, digest checks, image config retrieval, and repository tag listing. The oldgo.podman.io/image/v5specific transport, logging bridge, and reference handling have been removed in favor of directregclientintegration and smaller package-local helpers where Diun still has behavior that is specific to its model.This keeps the registry flow daemonless, preserves the existing compare-digest behavior that avoids unnecessary manifest downloads when a matching digest is already stored, and continues to support platform-aware manifest list handling. The migration also keeps Docker config based authentication and explicit registry options working with the new client.
As part of the switch, the registry package was simplified to rely on the parsed
Imagemodel directly, duplicate client state was removed, and registry logging now goes through a dedicatedregclientlogger bridge instead of the oldgo.podman.io/image/v5formatter. That restores readable request tracing while matching the transport that is actually in use.