Skip to content

feat: add missing optional parameters for SecretsManager.create #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k3-cat wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

feat: add missing optional parameters for SecretsManager.create #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions podman/domain/secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ def create(
data: bytes,
labels: Optional[Mapping[str, Any]] = None, # pylint: disable=unused-argument
driver: Optional[str] = None,
ignore: Optional[bool] = False,
replace: Optional[bool] = False,
) -> Secret:
"""Create a Secret.

Expand All @@ -105,13 +107,17 @@ def create(
data: Secret to be registered with Podman service.
labels: Ignored.
driver: Secret driver.
ignore: When True, ignore the request if a secret with the same name already exists.
replace: When True, replace an existing secret with the same name.

Raises:
APIError: when service returns an error
"""
params = {
"name": name,
"driver": driver,
"ignore": ignore,
"replace": replace,
}
response = self.client.post("/secrets/create", params=params, data=data)
response.raise_for_status()
Expand Down