feat: add missing optional parameters for SecretsManager.create#638
Open
k3-cat wants to merge 1 commit intocontainers:mainfrom
Open
feat: add missing optional parameters for SecretsManager.create#638k3-cat wants to merge 1 commit intocontainers:mainfrom
k3-cat wants to merge 1 commit intocontainers:mainfrom
Conversation
Added optional parameters 'ignore' and 'replace' to the method `SecretsManager.create` to handle existing secrets. Signed-off-by: k3-cat <k3-cat@outlook.com>
Honny1
requested changes
Mar 25, 2026
Member
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
LGTM, I would like to ask you to create some tests for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional parameters 'ignore' and 'replace' to the method
SecretsManager.createto handle existing secrets.Ref: https://docs.podman.io/en/latest/_static/api.html?version=latest#tag/secrets/operation/SecretCreateLibpod