Conversation
regro-cf-autotick-bot
requested review from
EZoni,
RemiLehe,
WeiqunZhang,
atmyers,
ax3l,
dpgrote and
roelof-groenewald
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
We need to patch AMReX first (version in changes file): conda-forge/amrex-feedstock#78 |
|
@conda-forge-admin, please rerender |
recipe/conda_build_config.yaml
Outdated
| python: | ||
| - 3.11 | ||
| - 3.12 | ||
| - 3.13 | ||
| - 3.14 |
There was a problem hiding this comment.
Added this because Python must be 3.11+ since pyAMReX 26.03 (https://github.com/AMReX-Codes/pyamrex/releases/tag/26.03).
The previous commit e39f51f raised errors like the following:
ERROR: Package 'amrex' requires a different Python: 3.10.20 not in '>=3.11'
There was a problem hiding this comment.
This breaks the automatic rerendering, see from https://github.com/conda-forge/conda-forge-webservices/actions/runs/24052856620/job/70152392549:
Traceback (most recent call last):
File "/opt/conda/envs/cf-feedstock-ops/bin/conda-smithy", line 10, in <module>
sys.exit(main())
^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/cli.py", line 760, in main
args.subcommand_func(args)
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/cli.py", line 610, in __call__
self._call(args, args.temporary_directory)
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/cli.py", line 613, in _call
configure_feedstock.main(
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/configure_feedstock.py", line 3019, in main
render_info.append(render_azure(env, config, forge_dir, return_metadata=True))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/configure_feedstock.py", line 2049, in render_azure
return _render_ci_provider(
^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/configure_feedstock.py", line 1290, in _render_ci_provider
migrated_combined_variant_spec = migrate_combined_spec(
^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/configure_feedstock.py", line 1115, in migrate_combined_spec
combined_spec = variant_add(combined_spec, migration)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/variant_algebra.py", line 315, in variant_add
return VARIANT_OP[operation](v1, v2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/variant_algebra.py", line 230, in op_variant_key_add
all_tuples = sorted(all_tuples_unsorted, key=sorter)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/variant_algebra.py", line 227, in <lambda>
sorter = lambda x: _version_order(
^^^^^^^^^^^^^^^
File "/opt/conda/envs/cf-feedstock-ops/lib/python3.12/site-packages/conda_smithy/variant_algebra.py", line 63, in _version_order
return ordering.index(v)
^^^^^^^^^^^^^^^^^
ValueError: '3.11' is not in list
There was a problem hiding this comment.
Trying the skip directive in recipe/recipe.yaml instead in 69ba436.
There was a problem hiding this comment.
There should be a field python that can be used for min version in recipe
There was a problem hiding this comment.
I see. Maybe this will work:
diff --git a/recipe/recipe.yaml b/recipe/recipe.yaml
index 3e2dd46..36b5209 100644
--- a/recipe/recipe.yaml
+++ b/recipe/recipe.yaml
@@ -8,6 +8,7 @@ context:
build: 0
mpi: ${{ mpi or "nompi" }} # is this still needed?
mpi_prefix: ${{ "nompi" if mpi == "nompi" else "mpi_" + mpi }}
+ python_min: "3.11"
package:
name: ${{ name|lower }}
@@ -18,7 +19,7 @@ source:
sha256: 0d17f27ca7463b9983a987629ea2c18e06a8e4d98b2b8c6affb7aacfe340690d
build:
- skip: python_impl == "pypy" or python == "3.10.* *_cpython"
+ skip: python_impl == "pypy"
# add build string so packages can depend on
# mpi or nompi variants
# dependencies:
@@ -61,13 +62,11 @@ requirements:
- amrex >=${{ version }}[build=${{ mpi_prefix }}_${{ pyamrex_precision }}_*]
- if: "mpi != 'nompi'"
then: ${{ mpi }}
- - python
- - pybind11
- numpy
- pip
- pybind11
- pybind11-abi
- - python
+ - python ${{ python_min }}.*
- setuptools
- vir-simd
- wheel
@@ -77,7 +76,7 @@ requirements:
then:
- ${{ mpi }}
- mpi4py
- - python
+ - python >=${{ python_min }}
- if: osx
then: libcxx
run_exports:
@@ -92,6 +91,7 @@ tests:
imports:
- amrex
pip_check: false
+ python_version: ${{ python_min }}.*
- script:
- if: win
then: set "OMP_NUM_THREADS=2"Note this also removes duplicate entries (python and pybind11).
There was a problem hiding this comment.
python_min might usually need to go into the build config file in the root of the repo, would need to check
Oops, I deleted my comment with nice links into the CF knowledge base by accident.
There was a problem hiding this comment.
There was a problem hiding this comment.
On the other hand we had a lot of Python 3.10 builds in these PR's CI checks (see e39f51f), so I don't see how that's excluded by default. So we do need to do something about it, no?
There was a problem hiding this comment.
Yes that makes sense. I thought CF had already migrated as in earlier versions
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping The following suggestions might help debug any issues:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24052856620. Examine the logs at this URL for more detail. |
|
@conda-forge-admin, please rerender |
…6.04.07.10.45.57 Other tools: - conda-build 26.3.0 - rattler-build 0.61.4 - rattler-build-conda-compat 1.4.11
There was a problem hiding this comment.
@conda-forge/pyamrex note also that if you use the following conda-forge.yml you get native linux-aarch64 and osx-arm64 builds (also Pixi support). For linux-ppc64le you don't need to repeat the key in the provider as build_platform allows for cross-compile and then the linux-* to linux-* emulation in testing doesn't need an explicit provider to be defined.
build_platform:
linux_ppc64le: linux_64
conda_build:
error_overlinking: true
pkg_format: '2'
conda_build_tool: rattler-build
conda_install_tool: pixi
conda_forge_output_validation: true
github:
branch_name: main
tooling_branch_name: main
provider:
linux_aarch64: default
osx_arm64: default
win: default
test: native_and_emulated
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
|
@conda-forge-admin, please rerender |
|
@ax3l you might want to poke it again or just locally rerender with as I think it just got stuck. |
|
I don't understand why we still see Python 3.10 builds, nor do I understand why they pass now. |
Because the feedstock hasn't been rerendered. @ax3l posted requests like #63 (comment) multiple times in a row while making pushes and I think the bot got confused and never finished the conda-smithy operations. Hence my comment #63 (comment). I also just rerender locally with the commands I've been posting as it is way faster and makes the PR not as noisy.
Because they are starting and then immediately having the build be skipped. So they are no-ops. |
|
@conda-forge-admin, please rerender |
…6.04.07.10.45.57 Other tools: - conda-build 26.3.0 - rattler-build 0.61.4 - rattler-build-conda-compat 1.4.11
|
Hm. Maybe there's a conda-forge bot bug, as looking at the bot CI run that @EZoni initiated: https://github.com/conda-forge/conda-forge-webservices/actions/runs/24109602658 I can see in the edit: Reported in conda-forge/conda-forge-webservices#1300. |
|
I pushed the result of #63 (comment) in fd2b25d, because the conda-forge bot trigger did not seem to have a net effect. Locally it seems to be consistent with what was observed in #63 (comment), in terms of |
|
Yay, thank you both for the great help! |
5 participants
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/23964116462 - please use this URL for debugging.