Skip to content

Fix macOS dependency declarations #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeyongjaykim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix macOS dependency declarations #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions softnet.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ class Softnet < Formula
homepage "https://github.com/cirruslabs/softnet"
version "0.19.0"
depends_on :macos

@hagemt121 hagemt121 Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I think this PR looks good! Who needs to review it? Thank you for making it, @jaeyongjaykim

I think you will still get one warning from this line, but that is better than four, which we have currently.

I'm not a maintainer, but I want this to be resolved as much as any user of this tap wants clean brew

@hagemt121 hagemt121 Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't edit these files, where are the goreleaser files that generate such Formula?

I don't see an obvious place in this repo. Editing this here (for now) is better than every user editing a local clone, no?

@wincent wincent Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't edit these files, where are the goreleaser files that generate such Formula?

They're linked in my comment above.

on_macos do
depends_on macos: :sequoia
end

url "https://github.com/cirruslabs/softnet/releases/download/0.19.0/softnet.tar.gz"
sha256 "1612e1296834aae0b6389650c7c5190add1ee8d71474e328691e67679ecda53c"
Expand All @@ -15,8 +18,6 @@ class Softnet < Formula
bin.install "softnet"
end

depends_on :macos => :sequoia

def caveats
<<~EOS
See the Github repository for more information
Expand Down
4 changes: 3 additions & 1 deletion tart.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ class Tart < Formula

depends_on "cirruslabs/cli/softnet"
depends_on :macos
on_macos do
depends_on macos: :ventura
end

url "https://github.com/cirruslabs/tart/releases/download/2.32.1/tart.tar.gz"
sha256 "8554ab4f7fc12afe52f9b7e3093a935673cbac737a83973d2db7a0683c814529"
Expand All @@ -19,7 +22,6 @@ class Tart < Formula
bin.write_exec_script "#{libexec}/tart.app/Contents/MacOS/tart"
end

depends_on :macos => :ventura
def post_install
generate_completions_from_executable(libexec/"tart.app/Contents/MacOS/tart", "--generate-completion-script")
end
Expand Down