Fix macOS dependency declarations - #16
Conversation
|
As noted in #14, these files have "DO NOT EDIT" markers in them: I think the fixes need to go in the upstream repos. Both of these have landed now: |
| @@ -7,6 +7,9 @@ class Softnet < Formula | |||
| homepage "https://github.com/cirruslabs/softnet" | |||
| version "0.19.0" | |||
| depends_on :macos | |||
There was a problem hiding this comment.
Edit: I think this PR looks good! Who needs to review it? Thank you for making it, @jaeyongjaykim
I think you will still get one warning from this line, but that is better than four, which we have currently.
I'm not a maintainer, but I want this to be resolved as much as any user of this tap wants clean brew
There was a problem hiding this comment.
If we can't edit these files, where are the goreleaser files that generate such Formula?
I don't see an obvious place in this repo. Editing this here (for now) is better than every user editing a local clone, no?
There was a problem hiding this comment.
If we can't edit these files, where are the goreleaser files that generate such Formula?
They're linked in my comment above.
|
@wincent — the upstream generator fixes have now merged. @fkorotkov-oai, could one of you merge this compatibility sync? The PR is clean and mergeable, and its generated changes match the fixes already merged upstream in Tart and Softnet. The new openai/tools migration will not automatically clean up existing cirruslabs/cli installations, so this still benefits current users. |
|
@wincent Aside: The migration PR away from I strongly suggest to add a deprecation notice to this tap FIRST pointing to the For future readers (after this mess is sorted out): brew uninstall cirruslabs/cli/tart cirruslabs/cli/softnet
brew untap cirruslabs/cli
brew tap openai/tools
brew install openai/tools/tart
brew doctor |
Summary
on_macosblocks forsoftnetandtartdepends_on :macosdeclarations while avoiding Homebrew 6 deprecation warningsCloses #14
Testing
brew info cirruslabs/cli/softnet cirruslabs/cli/tartbrew install yt-dlp