Skip to content

Fix macOS dependency declarations - #16

Open
jaeyongjaykim wants to merge 1 commit into
cirruslabs:masterfrom
jaeyongjaykim:fix-homebrew-macos-depends-on
Open

Fix macOS dependency declarations#16
jaeyongjaykim wants to merge 1 commit into
cirruslabs:masterfrom
jaeyongjaykim:fix-homebrew-macos-depends-on

Conversation

@jaeyongjaykim

@jaeyongjaykim jaeyongjaykim commented Jun 25, 2026

Copy link
Copy Markdown

Summary

  • move versioned macOS requirements into on_macos blocks for softnet and tart
  • preserve the bare depends_on :macos declarations while avoiding Homebrew 6 deprecation warnings

Closes #14

Testing

  • brew info cirruslabs/cli/softnet cirruslabs/cli/tart
  • brew install yt-dlp

@wincent

wincent commented Jul 3, 2026

Copy link
Copy Markdown

As noted in #14, these files have "DO NOT EDIT" markers in them:

This file was generated by GoReleaser. DO NOT EDIT.

I think the fixes need to go in the upstream repos. Both of these have landed now:

Comment thread softnet.rb
@@ -7,6 +7,9 @@ class Softnet < Formula
homepage "https://github.com/cirruslabs/softnet"
version "0.19.0"
depends_on :macos

@hagemt121 hagemt121 Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I think this PR looks good! Who needs to review it? Thank you for making it, @jaeyongjaykim

I think you will still get one warning from this line, but that is better than four, which we have currently.

I'm not a maintainer, but I want this to be resolved as much as any user of this tap wants clean brew

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't edit these files, where are the goreleaser files that generate such Formula?

I don't see an obvious place in this repo. Editing this here (for now) is better than every user editing a local clone, no?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't edit these files, where are the goreleaser files that generate such Formula?

They're linked in my comment above.

@Aternus

Aternus commented Jul 10, 2026

Copy link
Copy Markdown

@wincent — the upstream generator fixes have now merged. @fkorotkov-oai, could one of you merge this compatibility sync? The PR is clean and mergeable, and its generated changes match the fixes already merged upstream in Tart and Softnet. The new openai/tools migration will not automatically clean up existing cirruslabs/cli installations, so this still benefits current users.

@Aternus

Aternus commented Jul 10, 2026

Copy link
Copy Markdown

@wincent Aside: The migration PR away from cirruslabs/homebrew-cli is currently blocked because missing GORELEASER keys - which is not likely to be solved anytime soon: openai/tart#1277

I strongly suggest to add a deprecation notice to this tap FIRST pointing to the brew install openai/tools/tart

For future readers (after this mess is sorted out):

brew uninstall cirruslabs/cli/tart cirruslabs/cli/softnet
brew untap cirruslabs/cli
brew tap openai/tools
brew install openai/tools/tart
brew doctor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Homebrew warnings about depends_on :macos

4 participants