Skip to content

fix: replace implicit Prisma error with explicit 404 in getBookingToD… #28919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashs33244 wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −1
Open

fix: replace implicit Prisma error with explicit 404 in getBookingToD… #28919

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed1da1
fix: replace implicit Prisma error with explicit 404 in getBookingToD…
yashs33244 Apr 17, 2026
779aec3
test: assert HttpError 404 when booking not found during cancellation
yashs33244 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/features/bookings/lib/getBookingToDelete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { HttpError } from "@calcom/lib/http-error";
import prisma, { bookingMinimalSelect } from "@calcom/prisma";
import { credentialForCalendarServiceSelect } from "@calcom/prisma/selects/credential";

export async function getBookingToDelete(id: number | undefined, uid: string | undefined) {
return await prisma.booking.findUniqueOrThrow({
const booking = await prisma.booking.findUnique({
where: {
id,
uid,
Expand Down Expand Up @@ -111,6 +112,12 @@ export async function getBookingToDelete(id: number | undefined, uid: string | u
status: true,
},
});

if (!booking) {
throw new HttpError({ statusCode: 404, message: "Booking not found" });
}
Comment thread
yashs33244 marked this conversation as resolved.

return booking;
}

export type BookingToDelete = Awaited<ReturnType<typeof getBookingToDelete>>;
Loading