fix: replace implicit Prisma error with explicit 404 in getBookingToD…

[yashs33244]

findUniqueOrThrow leaks a Prisma-internal error message when a booking is not found. Replace with findUnique + explicit HttpError(404) so the API returns a clean, user-facing "Booking not found" message rather than a redacted Prisma internals string.

[github-actions]

Welcome to Cal.diy, @yashs33244! Thanks for opening this pull request.

A few things to keep in mind:

• This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
• Please review our Contributing Guidelines if you haven't already.
• Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

[Copilot]

Pull request overview

This PR prevents Prisma-internal “record not found” errors from leaking through the API when attempting to delete/cancel a booking, by converting the implicit Prisma exception into an explicit HTTP 404.

Changes:

• Replaces prisma.booking.findUniqueOrThrow with findUnique in getBookingToDelete.
• Throws an explicit HttpError with statusCode: 404 and message "Booking not found" when no booking is returned.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 154872e7-bd11-4786-ad1f-2c7c7db5737d

📥 Commits

Reviewing files that changed from the base of the PR and between 6ed1da1 and 779aec3.

📒 Files selected for processing (1)

• packages/features/bookings/lib/handleCancelBooking/test/handleCancelBooking.test.ts

✅ Files skipped from review due to trivial changes (1)

• packages/features/bookings/lib/handleCancelBooking/test/handleCancelBooking.test.ts

---

📝 Walkthrough

Walkthrough

The getBookingToDelete function in packages/features/bookings/lib/getBookingToDelete.ts was changed to use prisma.booking.findUnique and store the result in a local variable, then perform an explicit null check. If no booking is found the function now throws an HttpError with status code 404 and message "Booking not found". The function signature and exported types remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing Prisma's findUniqueOrThrow with explicit 404 error handling in getBookingToDelete.
Description check	✅ Passed	The description is directly related to the changeset, explaining the motivation for replacing findUniqueOrThrow with explicit HttpError(404) to avoid leaking Prisma internals.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}