Repository navigation
feat!: sync ic.did to spec 0.68.0 (5.0.0) - #17
Draft
cursor[bot] wants to merge 3 commits into
Draft
cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Regenerate Types.mo from the upstream management canister interface through spec 0.68.0. New record fields are breaking in Motoko because literals must name every field. Call.httpRequest is unchanged and still attaches the version-1 cost. Co-authored-by: Kamil Listopad <listopadkamil@gmail.com>
The 0.6.2 binary has Float32 support; stop telling people to build from source. Also record the moc 1.16.1 toolchain pin in AGENTS.md. Co-authored-by: Kamil Listopad <listopadkamil@gmail.com>
moc 1.16 warns M0269 on .vals(); the headers walk in Cost.httpRequest now uses .values(). Co-authored-by: Kamil Listopad <listopadkamil@gmail.com>
Kamirus
added a commit
that referenced
this pull request
Oct 9, 2026
The next version bump will fail to publish. `mops publish` runs the test suite, and `mops-publish.yml` still installs the latest mops (3.x), which dropped the dfx replica these tests need: ``` Tool 'pocket-ic' is not defined in [toolchain] section in mops.toml Run mops toolchain use pocket-ic 15.0.0 to install it ``` [#18](#18) pinned mops 2.24.0 in `mops-test.yml` only, so PR checks pass while the publish job is still exposed. That job hasn't run with mops 3 yet because no version bump has landed since; [#16](#16) and [#17](#17) (both 5.0.0) would be the first to hit it. Moving these tests to mops 3 needs mops-side changes: configurable test-canister cycles, auto-progress for HTTP outcalls, and a `TestThresholdKeys` subnet. Out of scope here. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand-built management-canister records compiled against
mo:ic/Typesneed new fields. This regeneratesTypes.mofrom the upstreamic.didthrough interface spec 0.68.0.Call.httpRequestis unchanged and still attaches the version-1 (ic0.cost_http_request) cost.Breaking (Motoko record literals must name every field)
Same for
IC.CanisterSettings/DefiniteCanisterSettings(minimum_incoming_canister_call_cycles,log_memory_limit,status_visibility),IC.FetchCanisterLogsArgs(filter), andCanisterStatusResult.memory_metrics(log_memory_store_size).IC.StatusVisibilityspells Candidpublicas#public_(reserved word).Pass
pricing_version = ?2only after attaching a version-2 reservation yourself. Motoko has noic0.cost_http_request_v2primitive yet (caffeinelabs/motoko#6379). A separate draft, #16, rewritesCall.httpRequestaround that primitive and should rebase onto this types bump.Additive
ic.flexible_http_requestplusIC.FlexibleHttpRequestArgs/Err/ResultandIC.HttpRequestResourceReport(spec 0.68.0, feat: Flexible canister HTTP outcalls and pay-as-you-go pricing dfinity/developer-docs#254).canister_infois now a query onTypes.Self(spec 0.67.0, feat: allow canister_info to be invoked via query calls dfinity/developer-docs#346).Why 5.0.0
New fields on records consumers construct are a Motoko compile break even when Candid-optional. Spec versions 0.64.0–0.68.0 (dfinity/developer-docs#302, #315, #252, #346, #254).
Housekeeping
didc0.6.2 from the GitHub release (docs inREGENERATING.md).[toolchain] moc1.16.1;[requirements] mocstays 1.4.0.