Repository navigation
ci: pin mops CLI to 2.24.0 in publish workflow - #20
Merged
Merged
Conversation
`mops publish` runs the test suite, which needs the dfx replica that only mops 2.x supports. mops-test.yml was pinned in #18; without the same pin the next version bump would fail to publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next version bump will fail to publish.
mops publishruns the test suite, andmops-publish.ymlstill installs the latest mops (3.x), which dropped the dfx replica these tests need:#18 pinned mops 2.24.0 in
mops-test.ymlonly, so PR checks pass while the publish job is still exposed. That job hasn't run with mops 3 yet because no version bump has landed since; #16 and #17 (both 5.0.0) would be the first to hit it.Moving these tests to mops 3 needs mops-side changes: configurable test-canister cycles, auto-progress for HTTP outcalls, and a
TestThresholdKeyssubnet. Out of scope here.🤖 Generated with Claude Code