Repository navigation
The pyroma hook builds no dependency from source (issue #1763) - #1768
Merged
Merged
Conversation
Section 4's pyroma hook takes --no-build. Where a locked package has no wheel for the hook's Python, uv stops and names it instead of building it from source over the network. The hooks test reads the new entry. The nine trees that carry the hook still have the old entry. A BACKLOG row excuses their cells, and each tree's landing trims its own name from it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
This was referenced Oct 16, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 4's pyroma hook takes
--no-build, so a locked package with no wheel for the hook's Python stops the hook and is named, instead of being built from source over the network (the failure mode of btclib-org/btclib#2685).The trees that carry the hook get the same entry in their own pull requests. Until each lands, a strict-xfail BACKLOG row excuses its cell, and a later commit here trims its name.
Evidence
pre-commit run --all-fileson 545e1d9BTCLIB_INTEGRATION=1 pytest tests/hooks_test.pyuv sync --locked --no-build --only-group check --python 3.15 --dry-runon btclib-node's lockpydantic-core==2.46.5(fresh reviewer)merge-treewith the union driver disabled, against main 5d3b33cDecision
The maintainer chose
--no-buildeverywhere (#1763), the standard first, then one pull request per tree.🤖 Generated with Claude Code