Repository navigation
The pyroma hook builds no dependency from source (issue btclib-org/.github#1763) - #1995
Merged
Merged
Conversation
…ithub#1763) The hook takes --no-build, as section 4 of the organization standard says. Where a locked package has no wheel for the hook's Python, uv stops and names it instead of building it from source over the network. The comment above the hook credits that to --no-build, not to --only-group. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
fametrano
enabled auto-merge (squash)
October 16, 2026 20:18
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
pmazzocchi
approved these changes
Oct 17, 2026
pmazzocchi
left a comment
pmazzocchi
left a comment
Contributor
There was a problem hiding this comment.
Approves head cddb2aa, following the human's decision to approve every pull request awaiting their review that is otherwise ready.
- Local review: none run by this session; the approval rests on the bot's ACK and CI.
- Bot review:
ACK cddb2aa553195b0ab7895b68255ab1f41730cdbf, #1995 (review) - Every check passed or was skipped on this head.
- Not checked: the gates were not re-run locally (CI's runs on this head are relied on).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyroma hook takes
--no-build, as section 4 of the organization standard says since btclib-org/.github#1768. A locked package with no wheel for the hook's Python then stops the hook and is named, instead of being built from source over the network.The comment above the hook credits that to
--no-build. After this lands, a commit in btclib-org/.github trims this tree from the BACKLOG row of btclib-org/.github#1763.Evidence
pre-commit run pyroma --all-filesandpre-commit run --all-filessphinx-build -n -Wmerge-treewith the union driver disabled, against main🤖 Generated with Claude Code