Bug: Learn Page correct post card and community card display issues#2414
Conversation
herzog0
left a comment
herzog0
left a comment
There was a problem hiding this comment.
Looking good to me, thanks for the fixes!
julhoang
left a comment
julhoang
left a comment
There was a problem hiding this comment.
@jlchilders11 – I've noticed a few UI issues on this page, it'd would be great if you are able to fix it here while we're at it 🙏
1/ We're missing a bit of space above the link.
2/ The new _post_card and _community_card now have fixed width so mobile and tablet cards are currently looking like this – perhaps we should confirm with Henry if the cards should look like the Post Card (with a max-width) or it should look like Boost Calendar Card (spanning he view-width). The Homepage and Community Page with similar masonry designs are applying the 1st strategy FYI.
3/ We currently have a lot of whitespace at the bottom of the page, is there a way to remove a grid row? 🤔
|
Just a minor merge conflict that needs to be taken care of, and I'll have a double check after this merges as #2403 also touches some of the same parts, but shouldn't be a big deal. |
jlchilders11
force-pushed
the
jc/bug-correct-learn-page
branch
from
638c7bf to
dc6f00f
Compare
jlchilders11
force-pushed
the
jc/bug-correct-learn-page
branch
from
dc6f00f to
6cf4568
Compare
Adopts the _community_card.html component from PR #2414 for the 'Boost community' section of the Learn page (replacing _join_card.html), along with its supporting CSS rewrite (learn-page.css cleanup, new community-card.css) and the registration in components.css. Renames boost_community_data item 'url' -> 'cta_url' to match the new component's expected shape.
6 participants
Issue: #2295
Summary & Context
Implements the new
post_carddesign for the learn page, as well as creating a new community card design.Changes
_post_cardinclude_community_cardinclude, with css and html_community_cardPlease list any potential risks or areas that need extra attention during review/testing
Screenshots
Light Mode:
Dark Mode:
Mobile:
Self-review Checklist
Frontend