feat(2403): wire up learn page#2446
Open
ycanales wants to merge 1 commit into
Open
Conversation
herzog0
approved these changes
May 20, 2026
Collaborator
herzog0
left a comment
There was a problem hiding this comment.
Hey Cristian, all good from my end, just a couple of comments that you should be aware of!
| kwargs={ | ||
| "version_slug": LATEST_RELEASE_URL_PATH_STR, | ||
| "library_view_str": "categorized", | ||
| "category_slug": category.slug, |
Collaborator
| <div class="item-a"> | ||
| {% with data=post_cards_data %} | ||
| {% include 'v3/includes/_post_cards_v3.html' with heading=data.heading posts=data.posts view_all_url=data.view_all_url view_all_label=data.view_all_label theme='teal' variant="content-card" %} | ||
| {% include 'v3/includes/_post_card.html' with heading=data.heading items=data.posts variant="card" theme="teal" layout="vertical" primary_cta_label=data.view_all_label primary_cta_url=data.view_all_url %} |
Collaborator
There was a problem hiding this comment.
Just a heads up that this will conflict with @jlchilders11's pr #2414.
In his PR he also fixes the designs of the boost community card, so QA must be aware that you're tackling this in your PR, if it moves to QA before Jeremy's one gets merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2403
Summary & Context
Changes
get_latest_post_cardsCategory.short_description: field, migration and Waftail snippet.LearnPageViewEntry-Libraryrelationship for library tags?Screenshots
Self-review Checklist
Frontend