Repository navigation
chore(deps-dev): bump vitest and @vitest/coverage-v8 together to 5.0.3 - #118
Merged
Merged
Conversation
coverage-v8 peers vitest at its exact version. main declares vitest ^5 next to coverage-v8 ^4.1.11, so the root vitest resolved to 4.1.11 (the coverage plugin's peer) and every workspace nested its own 5.0.0 - it worked by accident. Bumping either alone breaks it: #113 (coverage-v8 alone) nests the plugin away from the hoisted vitest ("Cannot find package '@vitest/coverage-v8'"), and #114's vitest bump hits ERESOLVE. Moves both to 5.0.3 in all five vitest workspaces, relocked so one copy of each is hoisted, and groups vitest + @vitest/* in dependabot.yml so they only ever move together. Supersedes #113.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #113 (
@vitest/coverage-v84.1.11 → 5.0.1), which failsUnit / Coverageinexamples/react-demowith:Why
@vitest/coverage-v8peersvitestat its exact version. main declaresvitest ^5.0.0next tocoverage-v8 ^4.1.11in all five vitest workspaces. So the lockfile hoistsvitest@4.1.11(coverage-v8's peer) to the root, and every workspace nests its ownvitest@5.0.0. It works by accident.Bumping either one alone breaks it:
npm installhits ERESOLVE against coverage-v8 4.What this does
vitestand@vitest/coverage-v8to^5.0.3inesign-service,react-demo,mint-only-demo,serverless-handler-demoandscripts. The lockfile is regenerated so there is exactly one copy of each, hoisted.vitestDependabot group (vitest,@vitest/*, all update types) abovenpm-minor-patch, so the two only ever move together.Verification
Coverage on every vitest workspace: service 558, react-demo 48, mint-only 24, serverless-handler 13, scripts 310, all passing.
After merging, #113 can be closed.