Repository navigation
chore(deps-dev): keep esign-react's @babel/preset-react on Babel 7 - #119
Merged
Merged
Conversation
#11 moved preset-react to 8 while preset-env and preset-typescript stayed on 7 (the @babel/* major ignore in dependabot.yml came later). That nests @babel/core 8 in packages/esign-react; main only works because babel-jest is hoisted and resolves the root core 7. Once jest is nested per workspace (the jest 30.5.2 bump in #114), babel-jest picks up core 8 and preset-env 7 refuses it: every esign-react suite fails with "Requires Babel ^7.0.0-0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #114 (npm-minor-patch group), where every
packages/esign-reactsuite failsUnit / Coveragewith:Why
#11 moved esign-react's
@babel/preset-reactto 8 while itspreset-envandpreset-typescriptstayed on 7. The@babel/*major ignore independabot.ymlarrived later. That nests@babel/core@8.0.1inpackages/esign-react/node_modules.main only works because jest and babel-jest are hoisted to the root, where they resolve the root
@babel/core@7.29.7. #114's jest 30.5.1 → 30.5.2 changes that: npm nests jest and babel-jest per workspace, so in esign-react babel-jest picks up core 8, and preset-env 7 refuses it.What this does
Puts
@babel/preset-reactback on^7.29.7and relocks. There is now one@babel/core(7.29.7) in the tree. The existing@babel/*major ignore keeps it from drifting again.Verification
make coveragegreen across every workspace. The only failures werescripts/5 s test timeouts under a load average of ~54; with--testTimeout=30000it's 310/310.#114 also needs #118: its vitest bump alone hits ERESOLVE against coverage-v8 4.