Add raise_on_unsupported_wav parameter to MediaFile.__init__#107
Merged
snejus merged 6 commits intobeetbox:masterfrom Apr 17, 2026
Merged
Add raise_on_unsupported_wav parameter to MediaFile.__init__#107snejus merged 6 commits intobeetbox:masterfrom
snejus merged 6 commits intobeetbox:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 16 16
Lines 832 832
Branches 117 117
=======================================
Hits 774 774
Misses 40 40
Partials 18 18 |
Contributor
Author
|
@snejus, please let me know if there is anything I need to edit. |
snejus
reviewed
Apr 17, 2026
snejus
reviewed
Apr 17, 2026
Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
3 tasks
snejus
added a commit
to beetbox/beets
that referenced
this pull request
Apr 18, 2026
Follow-up to #6526. This change moves the `remux_mpeglayer3_wav` call to before `library.Item.from_path` in `read_item`, so beets no longer depends on mediafile raising `FileTypeError` for MPEGLAYER3 WAV files. This is related to beetbox/mediafile#107.
Contributor
|
Thanks for fixing this so fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #105, this adds a
raise_on_unsupported_wavparameter toMediaFile.__init__(defaults toFalse) to make theFileTypeErrorfor non-PCM WAV formats optional rather than mandatory.This allows other mediafile users to continue reading basic audio properties (channels, samplerate, length, bitrate) from non-PCM WAV files, while beets can opt in to the behavior by passing
raise_on_unsupported_wav=True.Addresses the concern raised in #105.