Skip to content

Call remux_mpeglayer3_wav proactively in read_item#6544

Merged
snejus merged 2 commits intobeetbox:masterfrom
elainec2024:fix-remux-proactive
Apr 18, 2026
Merged

Call remux_mpeglayer3_wav proactively in read_item#6544
snejus merged 2 commits intobeetbox:masterfrom
elainec2024:fix-remux-proactive

Conversation

@elainec2024
Copy link
Copy Markdown
Contributor

Description

Follow-up to #6526. This change moves the remux_mpeglayer3_wav call to before library.Item.from_path in read_item, so beets no longer depends on mediafile raising FileTypeError for MPEGLAYER3 WAV files. This is related to beetbox/mediafile#107.

To Do

  • Documentation
  • Changelog
  • Tests

@elainec2024 elainec2024 requested a review from a team as a code owner April 17, 2026 22:33
@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now just update mediafile to >= 0.16.2 (Note >= instead of ^)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.18%. Comparing base (342a7c0) to head (2aeb57a).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
beets/importer/tasks.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6544   +/-   ##
=======================================
  Coverage   71.17%   71.18%           
=======================================
  Files         150      150           
  Lines       19176    19172    -4     
  Branches     3085     3084    -1     
=======================================
- Hits        13649    13648    -1     
+ Misses       4867     4864    -3     
  Partials      660      660           
Files with missing lines Coverage Δ
beets/importer/tasks.py 90.78% <40.00%> (+0.49%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snejus snejus force-pushed the fix-remux-proactive branch from f575d5a to 2aeb57a Compare April 18, 2026 14:40
@snejus snejus enabled auto-merge April 18, 2026 14:40
@snejus snejus merged commit 06f5e14 into beetbox:master Apr 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants