Skip to content

fix(S-378): skip enemy settlements in longest road calculation #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BriacLeGuilloux wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(S-378): skip enemy settlements in longest road calculation #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion catanatron/catanatron/models/board.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,12 @@ def longest_acyclic_path(board: Board, node_set: Set[int], color: Color):
while len(agenda) > 0:
node, path_thus_far = agenda.pop()

# Issue #378: Skip nodes occupied by enemy settlements.
# A settlement interrupts the road (Catan rule). We don't explore
# from a node that has an enemy settlement.
if board.is_enemy_node(node, color):
continue

able_to_navigate = False
for neighbor_node in STATIC_GRAPH.neighbors(node):
edge = tuple(sorted((node, neighbor_node)))
Expand All @@ -377,4 +383,4 @@ def longest_acyclic_path(board: Board, node_set: Set[int], color: Color):

paths.extend(paths_from_this_node)

return max(paths, key=len)
return max(paths, key=len) if paths else []
Loading