fix(S-378): skip enemy settlements in longest road calculation

[BriacLeGuilloux]

Hello,

I am a datascientist and I love Catan.
I am interested to help this project and to develop on it.

Please see a contribution. I am also on the discord: briac__35

[netlify]

👷 Deploy request for catanatron-staging pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	457a813

[broussal]

Hello, I've raised the issue #378 that you're trying to solve

I don't think your fix adresses the issue, actually it makes it worse

That's because setting an enemy node as your starting point does not causes the issue, it mitigates it. You want to be able to set an enemy node as your starting point AND ending point without ever going through one

[BriacLeGuilloux]

Hello,
Thank you for your answer.
I do not understand your point.
My PR only modify longest_acyclic_path, which calculate the longest path.

What I wanted to do, was to modify the calcul of the longest road, if an ennemy colony is set (as described in the ticket).

I tried to recreate the same board as the ticket and checked to see, if the calcul change. But I was able to do it.