Skip to content

fix: limit SAR application test to regions that have SAR enabled, plus simplification for docker asset test #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 2 commits into from
Oct 26, 2026
Merged

fix: limit SAR application test to regions that have SAR enabled, plus simplification for docker asset test #2096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0218463
fix: limit SAR application test to regions that have SAR enabled, fly…
iankhou Oct 26, 2026
37b1126
comment changes
iankhou Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/@aws-cdk-testing/cli-integ/lib/regions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,33 @@ export function allBut(exclude: string[]): string[] {
}

/**
* Regions that don't support CloudFormation Stack Refactoring
* Regions that support CloudFormation Stack Refactoring

@ShadowCat567 ShadowCat567 Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is comment was correct before the change, this is the list of regions that don't support Stack Refactoring.
Same for SAR, that comment is also odd.

@iankhou iankhou Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the comments to be less confusing (met in person to discuss).

*/
export const STACK_REFACTORING_REGIONS = allBut([
// Unsupported regions
'ap-southeast-5',
'ap-southeast-7',
'mx-central-1',
]);

/**
* Regions that support the Serverless Application Repository
*
* @see https://docs.aws.amazon.com/general/latest/gr/serverlessrepo.html
*/
export const SAR_REGIONS = allBut([
// Unsupported regions
'ap-northeast-3',
'af-south-1',
'ap-south-2',
'ap-southeast-3',
'ap-southeast-4',
'ap-southeast-5',
'ap-southeast-7',
'eu-central-2',
'eu-south-1',
'eu-south-2',
'il-central-1',
'ca-west-1',
'mx-central-1',
]);
3 changes: 1 addition & 2 deletions .../cli-integ/tests/cli-integ-tests/deploy/cdk-deploy-docker-asset-multi-region.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ integTest(
'deploy same docker asset to multiple regions',
withDefaultFixture(async (fixture) => {
const primaryRegion = fixture.aws.region;
const availableRegions = (process.env.AWS_REGIONS ?? 'us-east-1,us-west-2').split(',');
const secondaryRegion = availableRegions.find((r) => r !== primaryRegion) ?? 'us-west-2';
const secondaryRegion = ['us-east-1', 'us-west-2'].find((r) => r !== primaryRegion)!;

// Bootstrap the secondary region (with the same random qualifier the app
// is synthesized with, and a unique stack name to avoid clashing with
Expand Down
3 changes: 2 additions & 1 deletion ...iff---method-change-set-does-not-show-templateurl-change-for-sar-application.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { integTest, withSpecificFixture } from '../../../lib';
import { SAR_REGIONS } from '../../../lib/regions';

/**
* Regression test for https://github.com/aws/aws-cdk-cli/issues/2025
Expand All @@ -21,5 +22,5 @@ integTest(
// THEN
expect(diff).not.toContain('TemplateURL');
expect(diff).toContain('There were no differences');
}),
}, { aws: { regions: SAR_REGIONS } }),
);
Loading