Repository navigation
fix: limit SAR application test to regions that have SAR enabled, plus simplification for docker asset test - #2096
Merged
Conversation
…by simplification for docker asset test
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
iankhou
changed the title
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test runs that try to deploy a SAR resource to regions that don't support them. Supported regions are documented here: https://docs.aws.amazon.com/general/latest/gr/serverlessrepo.html.
It also removes logic from
packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/deploy/cdk-deploy-docker-asset-multi-region.integtest.tsthat depends onprocess.env.AWS_REGIONS, which isn't set in Atmosphere-enabled runs.This precedes an API change in an internal repo.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license