Skip to content

Track released broadcast Fragments to not release the same twice #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eflumerf merged 9 commits into from
Aug 21, 2026
+25 −3
Merged

Track released broadcast Fragments to not release the same twice #304

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0e8257
Track released broadcast Fragments to not release the same twice
eflumerf Jul 14, 2026
2bd8644
Clang-format
eflumerf Jul 14, 2026
08b6164
Merge branch 'develop' into eflumerf/TrackReleasedSubruns
eflumerf Jul 14, 2026
8507830
Limit list size
eflumerf Jul 15, 2026
8c5e344
Print a warning message whenever broadcasts are discarded. Abort Data…
eflumerf Jul 15, 2026
f6dd41d
clang-format
eflumerf Jul 15, 2026
23a188e
Make the Init Fragment message at run start an INFO
eflumerf Jul 15, 2026
177d050
Merge branch 'develop' into eflumerf/TrackReleasedSubruns
eflumerf Aug 14, 2026
c4465fb
Merge branch 'develop' into eflumerf/TrackReleasedSubruns
eflumerf Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions artdaq/ArtModules/ArtdaqSharedMemoryService_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class ArtdaqSharedMemoryService : public ArtdaqSharedMemoryServiceInterface
private:
std::unique_ptr<artdaq::SharedMemoryEventReceiver> incoming_events_;
std::list<std::shared_ptr<ArtdaqEvent>> event_ordering_;
std::set<artdaq::Fragment::sequence_id_t> released_broadcast_sequence_ids_;
size_t read_timeout_;
size_t subrun_closure_threshold_{1};
double safety_valve_timeout_s_{10.0};
Expand Down Expand Up @@ -309,9 +310,15 @@ std::shared_ptr<ArtdaqEvent> ArtdaqSharedMemoryService::ReceiveEvent(bool broadc
{
// First Fragment is broadcast (begin/end run/subrun), but there's more in event ordering!
TLOG(TLVL_RECEIVEEVENT) << "Returning Broadcast Fragment due to subrun closure";
output_event = event_ordering_.front();

if (released_broadcast_sequence_ids_.count(event_ordering_.front()->header->sequence_id) == 0)
{
output_event = event_ordering_.front();
released_broadcast_sequence_ids_.insert(event_ordering_.front()->header->sequence_id);
while (released_broadcast_sequence_ids_.size() > 1000) { released_broadcast_sequence_ids_.erase(released_broadcast_sequence_ids_.begin()); }
}
event_ordering_.pop_front();
break; // while(output_event == nullptr)
continue; // while(output_event == nullptr)
}
}
else if (current_subrun_ != 0 && first_sr > current_subrun_ + 1)
Expand Down