Skip to content

Track released broadcast Fragments to not release the same twice - #304

Merged
eflumerf merged 9 commits into
developfrom
eflumerf/TrackReleasedSubruns
Aug 21, 2026
Merged

Track released broadcast Fragments to not release the same twice #304
eflumerf merged 9 commits into
developfrom
eflumerf/TrackReleasedSubruns

Conversation

@eflumerf

Copy link
Copy Markdown
Contributor

No description provided.

@eflumerf eflumerf changed the title Eflumerf/track released subruns Track released broadcast Fragments to not release the same twice Jul 15, 2026
@eflumerf
eflumerf requested review from corrodis and ron003 August 21, 2026 12:30
@ron003

ron003 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

I suspect that the configuration key "init_fragment_count" is actually not configurable.
I mean, the user would never set it to anything other than 0.
Is there a place in the code where, if the key is not there, it can be inserted with the value of 0.
It's kind of a "hidden" or "non-user" or "system" key. I'm kind of surprised there isn't a better way to do this.
It's not that big of a deal, though -- could approve as is.

@eflumerf

Copy link
Copy Markdown
Contributor Author

It is set by DAQInterface when it inspects the system configuration ("bookkeeping"). It needs to be set in the input configuration so that DAQInterface can update it to the correct value.

@ron003

ron003 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What happens if the user adds "init_fragment_count":1 or anything other than 0 (is there a wrong value)?
Is there any way to not increase the (configuration) demands on the user?

@eflumerf

Copy link
Copy Markdown
Contributor Author

There is no wrong value. It just has to be in the input FHiCL document so that DAQInterface can overwrite it with the calculated value.

@eflumerf
eflumerf merged commit e03f052 into develop Aug 21, 2026
30 checks passed
@eflumerf
eflumerf deleted the eflumerf/TrackReleasedSubruns branch August 21, 2026 15:51
@github-project-automation github-project-automation Bot moved this from 📋 Triage to 🎉 Done in art-daq Work Tracker Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants