Skip to content

chore(deps): migrate to go.yaml.in/yaml/v3#27063

Merged
blakepettersson merged 1 commit into
argoproj:masterfrom
thevilledev:chore/go-yaml
Apr 1, 2026
Merged

chore(deps): migrate to go.yaml.in/yaml/v3#27063
blakepettersson merged 1 commit into
argoproj:masterfrom
thevilledev:chore/go-yaml

Conversation

@thevilledev
Copy link
Copy Markdown
Contributor

@thevilledev thevilledev commented Mar 29, 2026

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Motivation

gopkg.in/yaml.v3 is deprecated: https://github.com/go-yaml/yaml/tree/v3

Changes

Replace all direct imports with go.yaml.in/yaml/v3 v3.0.4, which is the same code under the supported new module path. The old module path remains as an indirect dependency of transitive deps.

$ go mod why -m  gopkg.in/yaml.v3
# gopkg.in/yaml.v3
github.com/argoproj/argo-cd/v3/notification_controller/controller
github.com/argoproj/notifications-engine/pkg/api
gopkg.in/yaml.v3

notifications-engine PR in argoproj/notifications-engine#436

gopkg.in/yaml.v3 is deprecated. Replace all direct imports
with go.yaml.in/yaml/v3 v3.0.4, which is the same code
under the supported new module path. The old module path
remains as an indirect dependency of transitive deps.

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Mar 29, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@thevilledev thevilledev changed the title build(deps): migrate to go.yaml.in/yaml/v3 chore(deps): migrate to go.yaml.in/yaml/v3 Mar 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.16%. Comparing base (99c51df) to head (383b942).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27063      +/-   ##
==========================================
+ Coverage   63.15%   63.16%   +0.01%     
==========================================
  Files         414      414              
  Lines       56485    56485              
==========================================
+ Hits        35671    35678       +7     
  Misses      17434    17434              
+ Partials     3380     3373       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thevilledev thevilledev marked this pull request as ready for review March 30, 2026 05:55
@thevilledev thevilledev requested review from a team as code owners March 30, 2026 05:55
Copy link
Copy Markdown
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question/comment as in argoproj/notifications-engine#436.

LGTM otherwise

@thevilledev
Copy link
Copy Markdown
Contributor Author

Detailed answer in argoproj/notifications-engine#436 (comment) but short version, a lot of dependencies still rely on the unmaintained library (like testify) and the indirect references will probably stay for a while.

@blakepettersson
Copy link
Copy Markdown
Member

Thanks!

@blakepettersson blakepettersson merged commit 5101db5 into argoproj:master Apr 1, 2026
29 of 30 checks passed
aniketpati1121 pushed a commit to aniketpati1121/argo-cd that referenced this pull request Apr 1, 2026
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants