Skip to content

chore(deps): migrate to go.yaml.in/yaml/v2#4683

Open
thevilledev wants to merge 2 commits into
argoproj:masterfrom
thevilledev:chore/go-yaml-in
Open

chore(deps): migrate to go.yaml.in/yaml/v2#4683
thevilledev wants to merge 2 commits into
argoproj:masterfrom
thevilledev:chore/go-yaml-in

Conversation

@thevilledev
Copy link
Copy Markdown
Contributor

@thevilledev thevilledev commented Apr 6, 2026

gopkg.in/yaml.v2 is deprecated and the YAML organisation maintained fork should be used instead, see: https://github.com/yaml/go-yaml#project-status

Replace all direct imports with go.yaml.in/yaml/v2 v2.4.4, which is the same code under the supported new module path. The old module path remains as an indirect dependency of transitive deps.

For full diff between v2.4.0 and v2.4.4 see comparison here. It's purely housekeeping and functionality is 1:1.

References to PRs from other Argo projects:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • My builds are green. Try syncing with master if they are not.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • I have run all tests locally (including the flaky ones) and they pass on my workstation
  • I have used LLM/AI/Agent tools for this PR but I am responsible for all code of this PR
  • I understand what the code does and WHY/HOW it works in several scenarios
  • I know if my code is just adding new functionality or changing old functionality for existing users
  • My organization is added to USERS.md.

gopkg.in/yaml.v2 is deprecated. Replace all direct imports
with go.yaml.in/yaml/v2 v2.4.4, which is the same code
under the supported new module path. The old module path
remains as an indirect dependency of transitive deps.

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.92%. Comparing base (16d28f8) to head (ed1c40c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
+ Coverage   84.89%   84.92%   +0.03%     
==========================================
  Files         164      164              
  Lines       18966    18966              
==========================================
+ Hits        16101    16107       +6     
+ Misses       2005     2002       -3     
+ Partials      860      857       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

Published E2E Test Results

  4 files    4 suites   3h 41m 22s ⏱️
120 tests 108 ✅  7 💤 5 ❌
486 runs  452 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit ed1c40c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

Published Unit Test Results

2 453 tests   2 453 ✅  3m 18s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit ed1c40c.

♻️ This comment has been updated with latest results.

@thevilledev thevilledev marked this pull request as ready for review April 12, 2026 08:31
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants