docs: correct clean log check guidance - #369
Draft
janicduplessis wants to merge 3 commits into
Draft
Conversation
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The agent guide treats exit code 0 from
logs --errorsas a clean-app check, but queries that print errors also exit 0. The exit-only wording replaced an empty-output check in 8719c80; the query contract still requires inspecting the result.Solution
Require both a successful query and no matching errors in captured logs. Align the CLI guides, README, and website, and clarify that an empty timeline does not prove launch or capture succeeded. Command behavior and the static skill remain unchanged.
Test plan
pnpm run test:e2eruns the real CLI against temporary workspaces: empty and matching-error queries both exit 0, a missing log directory is empty, and an invalid query exits 1. Assertions cover human output and JSON streams.Fixes #365