You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GC combines report rendering, cache policy, device cleanup, and EAS ownership checks in one 1,751-line command file, making each cleanup policy harder to review.
Solution
Move those responsibilities into GC-specific modules and keep registration, report collection, and cleanup order in the command, now 525 lines. Existing entry exports, dependency injection, ownership checks, and lock scope are preserved. The included plan tracks the native-command and guide follow-ups.
Test plan
Existing GC/EAS/device/cache suites pass before and after extraction. Exact text and serialized-report snapshots were recorded against main and pass unchanged here.
Moved helper bodies and external-tool arguments are unchanged. No live device or EAS deletion was run.
All repository checks pass: 3,537 unit tests, 20 fast end-to-end tests, runtime, formatting, lint, build, typecheck, and knip.
Combined verification of #369, #370, #374, #382, #384, #385, and #386 against main at 43da17e passes: 3,550 unit tests, 24 fast end-to-end tests, formatting, lint, build, typecheck, knip, runtime-floor checks, and website typecheck/build. This includes the newly merged reload command. All eight guide renders, two indexes, and 24 CLI captures remain byte-identical through extraction, including the independent fingerprint and build-lock guidance corrections.
Integration details to preserve when merging the native extraction with the fixes:
Guide extraction must move the current topic text, including the corrections from the other fixes.
The verified combined checkout is local-only at /private/tmp/stim-review-integration, commit d6aba6efa919cc2c0f28964b1ef445e28d44d15f. Individual PRs remain drafts; no PR merge or release was performed. Full native app/device matrix runs were not run.
The final combined run passed on its first attempt. Logs are retained under /private/tmp/stim-integration-reload-*.log. An earlier real-device process probe needed a retry on the prior baseline; it passed in isolation and in subsequent full runs without code or device changes. The independent CI timing failure in the existing build-lock process fixture is documented in #379.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GC combines report rendering, cache policy, device cleanup, and EAS ownership checks in one 1,751-line command file, making each cleanup policy harder to review.
Solution
Move those responsibilities into GC-specific modules and keep registration, report collection, and cleanup order in the command, now 525 lines. Existing entry exports, dependency injection, ownership checks, and lock scope are preserved. The included plan tracks the native-command and guide follow-ups.
Test plan
Fixes #371