Skip to content

MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache #22427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 3 commits into from
Jun 9, 2026
+4 −4
Merged

MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache #22427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98572db
Fix typo 'amd' -> 'and' in CompletableEventReaperTest comments
RonGamzu May 23, 2026
353e474
Fix typo 'instantiater' -> 'instantiator' in LeaderEpochFileCache Jav…
RonGamzu May 23, 2026
aa52d42
Merge remote-tracking branch 'origin/trunk' into fix/typo-fixes-reape…
RonGamzu Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...t/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void testExpired() {
UnsubscribeEvent event = new UnsubscribeEvent(calculateDeadlineMs(time.milliseconds(), timeoutMs));
reaper.add(event);

// Without any time passing, we check the reaper and verify that the event is not done amd is still
// Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event.future().isDone());
Expand Down Expand Up @@ -75,7 +75,7 @@ public void testCompleted() {
UnsubscribeEvent event = new UnsubscribeEvent(calculateDeadlineMs(time.milliseconds(), timeoutMs));
reaper.add(event);

// Without any time passing, we check the reaper and verify that the event is not done amd is still
// Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event.future().isDone());
Expand Down Expand Up @@ -106,7 +106,7 @@ public void testCompletedAndExpired() {
reaper.add(event1);
reaper.add(event2);

// Without any time passing, we check the reaper and verify that the event is not done amd is still
// Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event1.future().isDone());
Expand Down
2 changes: 1 addition & 1 deletion storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
* Offset = offset of the first message in each epoch.
* <p>
* Note that {@link #truncateFromStartAsyncFlush},{@link #truncateFromEndAsyncFlush} flush the epoch-entry changes to checkpoint asynchronously.
* Hence, it is instantiater's responsibility to ensure restoring the cache to the correct state after instantiating
* Hence, it is instantiator's responsibility to ensure restoring the cache to the correct state after instantiating
* this class from checkpoint (which might contain stale epoch entries right after instantiation).
*/
public final class LeaderEpochFileCache {
Expand Down
Loading